Skip to content

HDDS-5558. vUnit invocation unit() may produce NPE #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 8 commits into from
Aug 11, 2021
Merged

HDDS-5558. vUnit invocation unit() may produce NPE #2513

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
faacc91
HDDS-5558. vUnit invocation unit() may produce NPE
sky76093016 Aug 9, 2021
71d78d9
Use requireNonNull() method
sky76093016 Aug 9, 2021
efc85ae
Trigger notification
sky76093016 Aug 9, 2021
3475ed4
Trigger notification
sky76093016 Aug 9, 2021
7343460
Trigger notification
sky76093016 Aug 10, 2021
0ae858c
throw NullPointerException
sky76093016 Aug 10, 2021
a750363
code style
sky76093016 Aug 10, 2021
a2da489
fix code style and use IllegalArgumentException
sky76093016 Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/TimeDurationUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ public static long getTimeDurationHelper(String name, String vStr,
if (null == vUnit) {
LOG.warn("No unit for " + name + "(" + vStr + ") assuming " + unit);
vUnit = ParsedTimeDuration.unitFor(unit);
if(null == vUnit){
Comment thread
adoroszlai marked this conversation as resolved.
Outdated
throw new NullPointerException("Unexpected unit" + unit);
Comment thread
adoroszlai marked this conversation as resolved.
Outdated
}
} else {
vStr = vStr.substring(0, vStr.lastIndexOf(vUnit.suffix()));
}
Expand Down