Skip to content

HDDS-5459. Fix compile errors in TestReplicationManager #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChenSammi merged 1 commit into from
Jul 21, 2021
Merged

HDDS-5459. Fix compile errors in TestReplicationManager #2446

ChenSammi merged 1 commit into from
Jul 21, 2021

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Jul 21, 2021

What changes were proposed in this pull request?

#2429 removed ReplicationManager.processContainersNow(), but #2349 added some new calls it in the meantime. So now when both PRs are merged, we have compile errors.

[ERROR] /home/runner/work/ozone/ozone/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestReplicationManager.java:[1123,23] cannot find symbol
[ERROR]   symbol:   method processContainersNow()
[ERROR]   location: variable replicationManager of type org.apache.hadoop.hdds.scm.container.ReplicationManager
...

https://issues.apache.org/jira/browse/HDDS-5459

How was this patch tested?

Compiled Ozone. Ran TestReplicationManager.

@adoroszlai adoroszlai self-assigned this Jul 21, 2021
@adoroszlai adoroszlai changed the title HDDS-5459. Replication Manager should process containers synchronously for tests (#2429) HDDS-5459. Fix compile errors in TestReplicationManager Jul 21, 2021
@ChenSammi
Copy link
Contributor

ChenSammi commented Jul 21, 2021

@adoroszlai thanks for fixing the issue.

+1.
Wait for the CI result.

@ChenSammi ChenSammi merged commit 57d42b1 into apache:master Jul 21, 2021
@adoroszlai adoroszlai deleted the HDDS-5459-addendum branch July 21, 2021 19:53
@adoroszlai
Copy link
Contributor Author

adoroszlai commented Jul 21, 2021

Thanks @ChenSammi for reviewing and merging it.

@JacksonYao287 JacksonYao287 mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChenSammi ChenSammi Awaiting requested review from ChenSammi

@lokeshj1703 lokeshj1703 Awaiting requested review from lokeshj1703

Assignees

@adoroszlai adoroszlai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adoroszlai @ChenSammi