Skip to content

HDDS-5398. Avoid object creation in ReplicationManger debug log statements #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sodonnel merged 1 commit into from
Jun 30, 2021
Merged

HDDS-5398. Avoid object creation in ReplicationManger debug log statements #2379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ...dds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ private void deleteContainerReplicas(final ContainerInfo container,
});
containerManager.updateContainerState(container.containerID(),
HddsProtos.LifeCycleEvent.DELETE);
LOG.debug("Deleting empty container {} replicas,", container.containerID());
LOG.debug("Deleting empty container replicas for {},", container);
}

/**
Expand All @@ -621,8 +621,7 @@ private void handleContainerUnderDelete(final ContainerInfo container,
if (replicas.size() == 0) {
containerManager.updateContainerState(container.containerID(),
HddsProtos.LifeCycleEvent.CLEANUP);
LOG.debug("Container {} state changes to DELETED",
container.containerID());
LOG.debug("Container {} state changes to DELETED", container);
} else {
// Check whether to resend the delete replica command
final List<DatanodeDetails> deletionInFlight = inflightDeletion
Expand All @@ -638,8 +637,7 @@ private void handleContainerUnderDelete(final ContainerInfo container,
filteredReplicas.stream().forEach(rp -> {
sendDeleteCommand(container, rp.getDatanodeDetails(), false);
});
LOG.debug("Resend delete Container {} command",
container.containerID());
LOG.debug("Resend delete Container command for {}", container);
}
}
}
Expand Down Expand Up @@ -692,8 +690,7 @@ private void forceCloseContainer(final ContainerInfo container,
private void handleUnderReplicatedContainer(final ContainerInfo container,
final ContainerReplicaCount replicaSet,
final ContainerPlacementStatus placementStatus) {
LOG.debug("Handling under-replicated container: {}",
container.getContainerID());
LOG.debug("Handling under-replicated container: {}", container);
Set<ContainerReplica> replicas = replicaSet.getReplica();
try {

Expand Down