HDDS-5149 when source datanode download container tar from target datanode,but the target datanode container file missing,import error #2376
Conversation
…anode,but the target datanode container file missing,import error
…anode,but the target datanode container file missing,import error
…anode,but the target datanode container file missing,import error
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @cchenax for continuing work on this. In addition to inline comments, I also see that unit test from previous PR is removed.
| if (!containerData.getDbFile().exists()) { | ||
| LOG.warn("DBfile {} not exist", | ||
| containerData.getDbFile().toPath().toString()); | ||
| return; | ||
| } else if (!new File(containerData.getChunksPath()).exists()) { | ||
| LOG.warn("Chunkfile {} not exist", | ||
| containerData.getDbFile().toPath().toString()); | ||
| return; | ||
| } else if (!container.getContainerFile().exists()) { | ||
| LOG.warn("Containerfile {} not exist", | ||
| containerData.getDbFile().toPath().toString()); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Would it make sense to utilize
Container.scanMetadata()instead? More complete checks without introducing duplication.Ok,I will change it.thank you very much!
This comment from the previous PR still applies.
| task.setStatus(Status.DONE); | ||
| } | ||
| LOG.info("Container {} is replicated successfully", containerID); | ||
| task.setStatus(Status.DONE); |
There was a problem hiding this comment.
This would overwrite previous FAILED status.
|
/pending |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author. It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time. It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs. If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel." |
|
This should be handled by #3052 now. |
3 participants
What changes were proposed in this pull request?
fix if the metadatafile or chunksfile missing import export container error
What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-5149?filter=addedrecently
How was this patch tested?
ci