HDDS-5295. testCRLStatusReportPublisher fails to create CRLInfo #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I see the same issue UT failing |
Contributor
|
thanks for this work! i meet the same issue 2182. waiting for this to be merged! |
Contributor
|
Thank You @adoroszlai for the fix. |
Contributor
Author
|
Thanks @bharatviswa504 for reviewing and committing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-5154 made
x509CRLmandatory inCRLInfo. HDDS-4483 added a unit test wherex509CRLis not set. These two changes were tested without each other, hence passed. Together they fail onmaster: https://github.com/apache/ozone/runs/2732634889#step:4:853https://issues.apache.org/jira/browse/HDDS-5295
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/2734503211#step:4:918