Skip to content

Conversation

@sky76093016
Copy link
Contributor

What changes were proposed in this pull request?

Update link of wiki pages.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5178

How was this patch tested?

No test.

CONTRIBUTING.md Outdated
* Ozone website. Instructions are here: [Modifying the Ozone Website](https://cwiki.apache.org/confluence/display/HADOOP/Modifying+the+Ozone+Website)
* Developer docs. These are markdown files [checked into the Apache Ozone Source tree](https://github.com/apache/ozone/tree/master/hadoop-hdds/docs/content).
* The [wiki pages](https://cwiki.apache.org/confluence/display/HADOOP/Ozone+Contributor+Guide): Please contact us at [email protected] and we can provide you write access to the wiki.
* The [wiki pages](https://cwiki.apache.org/confluence/display/OZONE/Contributing+to+Ozone): Please contact us at [email protected] and we can provide you write access to the wiki.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update [email protected] -> [email protected]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mention of hadoop-ozone in the same file, Can you correct the repo name it is apache/ozone now
Fork apache/hadoop-ozone github repository (first time)

@sky76093016
Copy link
Contributor Author

sky76093016 commented May 3, 2021

@ayushtkn Thanks for your reminder,I will modify it right away.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.
Thank You @sky76093016 for the fix.

@cxorm
Copy link
Member

cxorm commented May 4, 2021

Thanks @sky76093016 for the work and @bharatviswa504, @ayushtkn for the reviews.

The Jira is for updating link in the first but we updated project information during careful reviews,
so I suggest that we could change the title of the Jira if you don't mind.
(For example, Update project information of Contribution guideline)

@sky76093016
Copy link
Contributor Author

sky76093016 commented May 4, 2021

@cxorm Thanks for your suggestion.
Of course, it looks like a good title.
After modifying the title of jira, I will change the title of the PR synchronously.

@sky76093016 sky76093016 changed the title HDDS-5178. Update link of wiki pages HDDS-5178. Update project information of Contribution guideline May 4, 2021
Copy link
Contributor

@cku328 cku328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sky76093016 for improving this guideline.

In the Who To Contact section of the same file, can you also update the dev-mailing list address and weekly meetings link?

image

CONTRIBUTING.md Outdated
* [Newbie Ozone jiras](https://s.apache.org/OzoneNewbieJiras)
* [All open and unassigned Ozone jiras](https://s.apache.org/OzoneUnassignedJiras)
* **Documentation Improvements**: You can submit improvements to either:
* Ozone website. Instructions are here: [Modifying the Ozone Website](https://cwiki.apache.org/confluence/display/HADOOP/Modifying+the+Ozone+Website)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Ozone website. Instructions are here: [Modifying the Ozone Website](https://cwiki.apache.org/confluence/display/HADOOP/Modifying+the+Ozone+Website)
* Ozone website. Instructions are here: [Modifying the Ozone Website](https://cwiki.apache.org/confluence/display/OZONE/Modifying+the+Ozone+Website)

This link also needs to be updated HADOOP -> OZONE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@sky76093016 sky76093016 requested a review from cku328 May 4, 2021 04:39
Copy link
Contributor

@cku328 cku328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @sky76093016 for the update.

@bharatviswa504 bharatviswa504 merged commit 2e07c9f into apache:master May 4, 2021
@bharatviswa504
Copy link
Contributor

Thank you @sky76093016 for the contribution,
@ayushtkn, @cku328, and @cxorm for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants