Skip to content

Conversation

@cchenax
Copy link
Contributor

@cchenax cchenax commented Apr 28, 2021

What changes were proposed in this pull request?

when datanode restart,reload the container data will check the chunksfile

What is the link to the Apache JIRA

https://issues.apache.org/jira/projects/HDDS/issues/HDDS-5150?filter=addedrecently

How was this patch tested?

cchenaxchen added 2 commits April 27, 2021 12:11
…tainer reader will not verfiy the chunks directory missing
…tainer reader will not verfiy the chunks directory missing
@cchenax cchenax changed the title HDDS-5150 if container chunks is missing,the datanode restart the con… HDDS-5150 when datanode restart,reload the container data will check the chunksfile Apr 28, 2021
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cchenax for proposing this improvement. However, I don't think metadata load should be prevented just because chunk dir is missing. The DB may be useful anyway, to find out exactly what is missing. Also, returning early from this method with a log message would just hide errors.

Ozone already has a tool (container scanner) to detect missing data and more problems.

@adoroszlai
Copy link
Contributor

/pending

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

/pending

@github-actions
Copy link

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."

@github-actions github-actions bot closed this Jul 28, 2021
@errose28
Copy link
Contributor

Looks like this is now covered by #3052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants