-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-5150 when datanode restart,reload the container data will check the chunksfile #2192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tainer reader will not verfiy the chunks directory missing
…tainer reader will not verfiy the chunks directory missing
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cchenax for proposing this improvement. However, I don't think metadata load should be prevented just because chunk dir is missing. The DB may be useful anyway, to find out exactly what is missing. Also, returning early from this method with a log message would just hide errors.
Ozone already has a tool (container scanner) to detect missing data and more problems.
|
/pending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this issue as un-mergeable as requested.
Please use /ready comment when it's resolved.
Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)
/pending
|
Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author. It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time. It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs. If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel." |
|
Looks like this is now covered by #3052 |
What changes were proposed in this pull request?
when datanode restart,reload the container data will check the chunksfile
What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-5150?filter=addedrecently
How was this patch tested?