Skip to content

Conversation

@elek
Copy link
Member

@elek elek commented Apr 8, 2021

JIRA: https://issues.apache.org/jira/browse/HDDS-5074

What changes were proposed in this pull request?

Guava has a tmp directory related CVE (CVE-2020-8908).

Based on my best knowledge Ozone is not affected, but it's hard to explain this situation for all the automated tools. Let's just bump the version to the latest one...

How was this patch tested?

Full CI passed.

And checked if guava jar is really updated in the final distribution:

image

@elek elek changed the title Bump Guava version HDDS-5074. Bump Guava version Apr 8, 2021
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elek for the upgrade.

@jojochuang
Copy link
Contributor

LGTM
I just want to say that the description of that alert isn't accurate. Simply updating to guava 30 doesn't help. It requires removing the API call usage in the code. Fortunately we don't seem to use it in Ozone.

@elek
Copy link
Member Author

elek commented Apr 13, 2021

Thanks, the review @adoroszlai and @jojochuang. Agree with the comment, it's not a security fix. Just makes less false-positive problems reported... Merging it now...

@elek elek merged commit aa44905 into apache:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants