HDDS-5023. Datanodes should always use MLV 0 when no VERSION file is present. #2080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avijayanhwx
approved these changes
Mar 25, 2021
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Mar 25, 2021
* HDDS-3698-nonrolling-upgrade: HDDS-5023. Datanodes should always use MLV 0 when no VERSION file is present. (apache#2080)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since older versions of the code did not have a VERSION file for datanodes, use the presence of the datanode.id file to determine whether the datanode is being started on a fresh install and should use the latest layout version, or being started as part of an upgrade and should use the initial layout version.
What is the link to the Apache JIRA
HDDS-5023
How was this patch tested?
Added fix to HDDS-4181 acceptance tests, and the MLV tests there verified that pre-finalize datanodes are using the correct MLV when pre-finalized.