Skip to content

Conversation

@smengcl
Copy link
Contributor

@smengcl smengcl commented Jan 31, 2021

3rd time's the charm

What changes were proposed in this pull request?

Use ClientProtocol directly in Adapter and FS. Completely remove the usage of OzoneClientAdapter interface in OFS.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3805

How was this patch tested?

All existing UTs/robots should pass as-is.

What is the difference of this PR since #1363?

  1. Rebased to the latest master branch
  2. Renamed internal class BasicRootedOzoneClientAdapterImpl to BasicRootedOzoneFileSystemHelper as suggested.

Change-Id: I1bb0dd193fc51145bd5921287a701480d09ca92b
Change-Id: Ide653e2299c0071226f8f338624ad486f703bd43
@smengcl smengcl requested a review from elek January 31, 2021 21:17
@smengcl smengcl self-assigned this Jan 31, 2021
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review @smengcl, and thanks for the patch. The concept looks good to me.

In fact, I am very interested about the mentioned future:

 * Previously BasicRootedOzoneClientAdapterImpl. Might be merged with
 * BasicRootedOzoneFileSystem in the future.

But it seems to be a reasonable step forward to it.

As far as I see it has never been passed the CI, would be great to get a green build...

@elek
Copy link
Member

elek commented Apr 19, 2021

/pending As far as I see it has never been passed the CI, would be great to get a green build...

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

As far as I see it has never been passed the CI, would be great to get a green build...

@github-actions
Copy link

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."

@github-actions github-actions bot closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants