Skip to content

Conversation

@captainzmc
Copy link
Member

@captainzmc captainzmc commented Jan 26, 2021

What changes were proposed in this pull request?

An exception "Unknown command type: DeleteContainer" occurs when we delete a container. This is a bug that needs to be fixed.
In fact, this part of the interface backend is already implemented, just not called.
image

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4746

How was this patch tested?

UT added

@avijayanhwx
Copy link
Contributor

avijayanhwx commented Jan 26, 2021

Thanks for working on this @captainzmc. Can we find out why and in which JIRA this command was removed?

@adoroszlai
Copy link
Contributor

Please see #214 and #389 for previous attempts to fix this.

@captainzmc
Copy link
Member Author

Thanks for working on this @captainzmc. Can we find out why and in which JIRA this command was removed?

hi @avijayanhwx This interface is not removed, this interface didn't work properly from the beginning.

@captainzmc
Copy link
Member Author

Please see #214 and #389 for previous attempts to fix this.

@adoroszlai Thanks for the reminding. I will confirm the current status of #389.

@captainzmc
Copy link
Member Author

Hi @maobaolong, Are you currently working on fixing #389? If not, I hope to take this Task, because we will use this interface.

@maobaolong
Copy link
Member

@captainzmc Sure, please feel free to take it, hope you can finish this.

@captainzmc captainzmc changed the title HDDS-4746. Fix delete container occurs unknown command type. WIP HDDS-4746. Fix delete container occurs unknown command type. Jan 26, 2021
@captainzmc
Copy link
Member Author

captainzmc commented Jan 27, 2021

By looking at the issues mentioned in #214 and #389, I found that in #1338(this PR is used to remove empty containers) these issues were well addressed and explained, by fixed ContainerReportHandler.
I think we can continue with the current PR review. cc @maobaolong @adoroszlai

@captainzmc captainzmc changed the title WIP HDDS-4746. Fix delete container occurs unknown command type. HDDS-4746. Fix delete container occurs unknown command type. Jan 27, 2021
@captainzmc captainzmc requested a review from ChenSammi January 27, 2021 02:30
@captainzmc
Copy link
Member Author

captainzmc commented Feb 1, 2021

We use this feature because HDDS-4334 relies on it. Now #1338 has implemented the remove all empty containers. So we can delete all the files through OFS, and the empty container will be deleted automatically. So we don't think it's necessary anymore, I'm going to turn off the PR.
If there are other features needed, we can start this PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants