Skip to content

HDDS-4735. Fix typo in hdds.proto #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cku328 merged 4 commits into from
Jan 26, 2021
Merged

HDDS-4735. Fix typo in hdds.proto #1837

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45cbc90
HDDS-4735. Fix typo in hdds.proto
symious Jan 24, 2021
b520bb4
trigger new CI check
symious Jan 24, 2021
9f344a9
HDDS-4735. Fix some other typos
symious Jan 25, 2021
9df91ce
HDDS-4735. Fix some other typos
symious Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hadoop-hdds/interface-client/src/main/proto/hdds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ message NodePool {

/**
* LifeCycleState for SCM object creation state machine:
* ->Allocated: allocated on SCM but clean has not started creating it yet.
* ->Allocated: allocated on SCM but client has not started creating it yet.
* ->Creating: allocated and assigned to client to create but not ack-ed yet.
* ->Open: allocated on SCM and created on datanodes and ack-ed by a client.
* ->Close: container closed due to space all used or error?
Copy link
Contributor

@amaliujia amaliujia Jan 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: as this PR is fixing typo, maybe remove the question mark in Close: container closed due to space all used or error?

Copy link
Contributor Author

@symious symious Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, have fixed the question mark.

Expand Down