HDDS-2505. Fix logic related to SCM address calculation in HddsUtils #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@adoroszlai , can you please the unit test failures. They seem related. |
Contributor
Author
|
Thanks @bshashikant for checking this. I don't see related unit test failures. But this can definitely wait until @elek manages to get a fully green CI run. Then I can update this PR with those fixes to get more relevant test results. |
xiaoyuyao
reviewed
Nov 20, 2019
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
approved these changes
Nov 20, 2019
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
LGTM, just one minor comment inline.
Member
|
Thanks the patch @adoroszlai and the review @xiaoyuyao I am merging it right now. The acceptance test failure seems to be unrelated (and will be fixed by #282 ) |
Contributor
Author
|
Thanks @elek for committing it. |
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
…ID at info level (apache#5481) (apache#183) (cherry picked from commit 6bf3886) Co-authored-by: Shivam Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ifbranches inHddsUtilsmethods, as reported by SonargetHostNameFromConfigKeysalready supports multiple keys for fallbackOptionalIntinstead ofOptional<Integer>for portsgetScmServiceRpcAddresses()assertEqualsargsString.formatin logging@paramwithout descriptionhttps://issues.apache.org/jira/browse/HDDS-2505
How was this patch tested?
Unit tests (host/port lookup has good coverage). Also ran
ozoneacceptance test locally.