HDDS-2492 Fix test clean up issue in TestSCMPipelineManager.

[timmylicheng]

What changes were proposed in this pull request?

#HDDS-2492
Close pipeline in TestSCMPipelineManager#testPipelineOpenOnlyWhenLeaderReported.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2492

(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)

Please replace this section with the link to the Apache JIRA)

How was this patch tested?

UT
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

[adoroszlai]

Thanks @timmylicheng for fixing this.

There is one more place where pipelineManager.close() is missing: in testPipelineCreationFailedMetric. Can you please add that one, too?

Also, testPipelineReport was deleted in #23, but restored (I believe accidentally, when resolving some merge conflict) in #29. Now it is failing, because pipeline health requires leader to be set, but the pipeline in the test has 3 non-leader DNs. If it's simple to fix, can you please also do it in this change? If not, I guess it can be removed again. cc @ChenSammi @swagle

I think commit and PR title have the wrong Jira number, it should be HDDS-2492.

[timmylicheng]

Thanks @timmylicheng for fixing this.

There is one more place where pipelineManager.close() is missing: in testPipelineCreationFailedMetric. Can you please add that one, too?

Also, testPipelineReport was deleted in #23, but restored (I believe accidentally, when resolving some merge conflict) in #29. Now it is failing, because pipeline health requires leader to be set, but the pipeline in the test has 3 non-leader DNs. If it's simple to fix, can you please also do it in this change? If not, I guess it can be removed again. cc @ChenSammi @swagle

I think commit and PR title have the wrong Jira number, it should be HDDS-2492.

I will add it.
In terms of testPipelineReport test, https://issues.apache.org/jira/browse/HDDS-2499 will fix the test. The issue was not just the test itself.
Thanks for reviewing! @adoroszlai

[adoroszlai]

Thanks @timmylicheng for making the additional change.

[ChenSammi]

+1. Thanks for @timmylicheng, and @adoroszlai for the review.