Skip to content

HDDS-2402. Adapt hadolint check to improved CI framework #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elek merged 4 commits into from
Jan 26, 2021
+12 −16
Merged

HDDS-2402. Adapt hadolint check to improved CI framework #1778

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0fb1c5a
HDDS-2402. Adapt hadolint check to improved CI framework
Jan 12, 2021
5c5dd03
HDDS-2402. To simplify the script
Jan 13, 2021
8f91ed1
HDDS-2402. Simplify loop body
Jan 14, 2021
13a3583
trigger new CI check
adoroszlai Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions hadoop-ozone/dev-support/checks/hadolint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,24 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
REPO_DIR="$DIR/../../.."

ERROR=0


for Dockerfile in $(find "$REPO_DIR/hadoop-ozone" "$REPO_DIR/hadoop-hdds" -name Dockerfile | sort); do
echo "Checking $Dockerfile"
REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target/hadolint"}
mkdir -p "$REPORT_DIR"
REPORT_FILE="$REPORT_DIR/summary.txt"
Comment thread
symious marked this conversation as resolved.

for Dockerfile in $(find hadoop-ozone hadoop-hdds -name Dockerfile | sort); do
result=$( hadolint $Dockerfile )
if [ ! -z "$result" ]
then
echo "$result"
echo ""
ERROR=1
echo "$result" | tee -a "$REPORT_FILE"
fi
Comment thread
symious marked this conversation as resolved.
Outdated
done

if [ "$ERROR" = 1 ]
wc -l "$REPORT_FILE" | awk '{print $1}'> "$REPORT_DIR/failures"

if [ -s "${REPORT_FILE}" ]
then
echo ""
echo ""
echo "Hadolint errors were found. Exit code: 1."
echo "" | tee -a "$REPORT_FILE"
echo "" | tee -a "$REPORT_FILE"
echo "Hadolint errors were found. Exit code: 1." | tee -a "$REPORT_FILE"
exit 1
fi