HDDS-4622: Use singe server raft cluster in MiniOzoneCluster. #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlenGeng-awx
force-pushed
the
HDDS-4622-latest
branch
from
fd11594 to
d89a6fd
Compare
amaliujia
reviewed
Dec 30, 2020
Contributor
Author
Contributor
|
Overall LGTM. There were comments that I left on #1738 but those comments are addressed in this PR. |
Contributor
|
cc @amaliujia |
GlenGeng-awx
force-pushed
the
HDDS-4622-latest
branch
2 times, most recently
from
d090bbd to
eaee2d4
Compare
GlenGeng-awx
force-pushed
the
HDDS-4622-latest
branch
from
eaee2d4 to
8686b9a
Compare
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use SCMHAManagerImpl and SCMRatisServerImpl instead of MockSCMHAManager and MockRatisServer in MiniOzoneCluster.
The MockRatisServer and MockSCMHAManager can not fully test the HA code.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4622
How was this patch tested?
CI