-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-4594. Add namespace quota to documentation #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @captainzmc |
|
|
||
| c. When bucket namespace quota is enabled, the totoal number of keys under the bucket, cannot exceed the bucket namespace quota. | ||
|
|
||
| d. Linked buckets do not consume namespace quota. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether 'e' in Storage Space applies equally to Namespace quota. If so, we need to list.
|
@amaliujia Thanks for your patch. Could you also update the Client Usage about Namespace quota? |
|
comments addressed. |
linyiqun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When reading this quota documentation, I am thinking for the set quota cases: as we support both volume and bucket quota, will we check the below scenarios that only either one quota was set, then try to enable another quota:
- Bucket quota already set, then user try to set volume quota, will we check volume quota must more than total bucket quota?
- Volume quota already set, then user try to set bucket quota, will we check the total bucket quota, so that will not exceed volume quota? (I remember this check already contained)
|
I think for namespace, it will be different than space. Namespace quota is independent on each level (volume, bucket, etc.) Namespace quota on volume only controls number of bucket names, and namespace on bucket only controls keys in that bucket. This is different from space quota in which volume quota has a relationship with its buckets quotas. What currently is missing is the ability to control all keys within a volume. If there is use case, we could add support for it. |
|
Thanks for @amaliujia's update. I think there are some case we need to confirm. |
| bin/ozone sh volume clrquota --space-quota /volume1 | ||
| bin/ozone sh bucket clrquota --space-quota /volume1/bucket1 | ||
| bin/ozone sh volume clrquota --space-quota --namespace-quota /volume1 | ||
| bin/ozone sh bucket clrquota --space-quota --namespace-quota /volume1/bucket1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something wrong with the directory structure. At present is:
#space quota
……
#namespace quota
……
## clear quota
## check quota and usage
We can change it to:
#space quota
……
## clear quota
## check quota and usage
#namespace quota
……
## clear quota
## check quota and usage
or
#space quota and namespace quota
……
## clear quota
## check quota and usage
|
@captainzmc |
Agree, I'll remove the namespace restriction in #1723. |
|
finally I was able to re-trigger the CI (seemed that CI didn't work for a while). Any other comments on this PR? |
captainzmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
hi @linyiqun, any other suggestions about this PR?
|
Also +1 from me. |
|
Merged this PR. Thanks for @amaliujia's patch and @linyiqun‘s review. |
What changes were proposed in this pull request?
Add namespace quota to documentation
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4594
How was this patch tested?
UT