HDDS-4622. Use single ratis server in MiniOzoneCluster tests for SCM #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
changed the title
amaliujia
changed the title
amaliujia
force-pushed
the
HDDS-2823-single-ratis-server
branch
from
9105f39 to
2468a6e
Compare
Contributor
Author
|
cc: @GlenGeng |
amaliujia
commented
Dec 26, 2020
| @Config(key = "ratis.storage.dir", | ||
| type = ConfigType.STRING, | ||
| defaultValue = "", | ||
| defaultValue = "scm-ratis", |
Contributor
Author
There was a problem hiding this comment.
This is workaround to config SCM ratis storage dir value. The usual way that config value in SCMHAConfiguration seems break. I will file a JIRA to fix it.
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
We won't need this line of change after #1739
| GenericTestUtils.waitFor(() -> { | ||
| final int healthy = scm.getNodeCount(HEALTHY); | ||
| // When SCM HA is not enabled, scm is always leader. | ||
| final boolean checkScmLeader = scm.checkLeader(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The intention is to replace MockRatisServer by production Ratis server in integration tests (tests that use
MiniOzoneClusters)What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4622
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)