Skip to content

Conversation

@elek
Copy link
Member

@elek elek commented Nov 14, 2019

What changes were proposed in this pull request?

HDDS-2400 introduced a github actions workflow for each "push" event. It turned out that pushing to a forked repository doesn't trigger this event even if it's part of a PR.

We need to enable the execution for pull_request events:

References:

Note: By default, a workflow only runs when a pull_request's activity type is opened, synchronize, or reopened. To trigger workflows for more activity types, use the types keyword.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2482

How was this patch tested?

  1. I pushed this change to the master branch of elek/hadoop-ozone
  2. I created a pull request by an other user (until know I tested everything with PR between branches by the same user)
  3. Pull request has been started (rename contribution to contributing elek/ozone#7)

@elek elek changed the title github worflow actions full pull requests HDDS-2482. Enable github actions for pull requests Nov 14, 2019
@anuengineer
Copy link
Contributor

nice , yes, on push and pull_request makes sense. So I will wait for the build to finish and commit this. Thanks

@anuengineer
Copy link
Contributor

if unit fails, I am hoping the run fails :) ?

@anuengineer anuengineer merged commit 0e403a5 into apache:master Nov 15, 2019
@anuengineer
Copy link
Contributor

Bravo, amazing work. Thank you.

@elek
Copy link
Member Author

elek commented Nov 15, 2019

Thanks the commit @anuengineer It seems to be working, for example in this pr:
#142

I will gradually turn off the kubernetes based tests (starting with author/findbugs/chekstyle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants