HDDS-4575: Refactor SCMHAManager and SCMRatisServer with RaftServer.Divison #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlenGeng-awx
force-pushed
the
HDDS-4575
branch
from
4c2c041 to
8b18600
Compare
GlenGeng-awx
force-pushed
the
HDDS-4575
branch
from
8b18600 to
8a84b03
Compare
| @Override | ||
| public RaftGroupId getRaftGroupId() { | ||
| public RaftServer.Division getDivision() { | ||
| return null; |
Contributor
There was a problem hiding this comment.
Do we allow Division to be null?
Contributor
Author
There was a problem hiding this comment.
No, we don't allow null Divison in real env.
| .setStateMachine(new SCMStateMachine()) | ||
| .build(); | ||
|
|
||
| this.division = server.getDivision(haGrpBuilder.getRaftGroupId()); |
Contributor
There was a problem hiding this comment.
Any way to guarantee division is not null?
Contributor
Author
There was a problem hiding this comment.
You won't get a null, instead, the call will throw a GroupMismatchException in this situation.
GlenGeng-awx
force-pushed
the
HDDS-4575
branch
from
8a84b03 to
5d9b029
Compare
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Simplify SCMHAManager and SCMRatisServer with RaftServer.Division
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4575
How was this patch tested?
CI