HDDS-4551: Remove checkLeader in PipelineManager. #1658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ChenSammi @timmylicheng @nandakumar131 Please take a look at this PR! Thanks! |
GlenGeng-awx
force-pushed
the
HDDS-4551
branch
2 times, most recently
from
fba0fb9 to
e25f101
Compare
GlenGeng-awx
force-pushed
the
HDDS-4551
branch
from
e25f101 to
f5b975d
Compare
GlenGeng-awx
force-pushed
the
HDDS-4551
branch
from
034ab18 to
b624ef7
Compare
Contributor
|
+1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We do not need isLeader check in PipelineManager, just remove them.
By design, we just need do isLeader check when receiving rpc requests and firing datanode command.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4551
How was this patch tested?
CI