HDDS-4542. Need throw exception to trigger FailoverProxyProvider of SCM client to work #1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CM client to work
Contributor
Author
|
@ChenSammi @timmylicheng @nandakumar131 Please take a look at this PR. This is one of the hot fix found during the phase 1.5 test. |
timmylicheng
reviewed
Dec 3, 2020
| return ScmContainerLocationResponse.newBuilder() | ||
| .setCmdType(request.getCmdType()).setTraceID(request.getTraceID()) | ||
| .setSuccess(false).setStatus(Status.SCM_NOT_LEADER).build(); | ||
| throw new ServiceException(new IOException("SCM IS NOT LEADER")); |
Contributor
There was a problem hiding this comment.
Shall we expose scm names or ipadress for the current SCM in the exception message?
Contributor
Author
There was a problem hiding this comment.
@timmylicheng Thanks for looking at this patch !
Good point !
As far as I know, the failover proxy provider will print out the IP address, along with the exception.
We need revisit this code in future, when the failover proxy provider should support leaderHint. I've file a jira to track this task, https://issues.apache.org/jira/browse/HDDS-4545
Contributor
|
Thanks @GlenGeng 's contribution. Overall LGTM. Just left a comment inline. |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ScmBlockLocationProtocolServerSideTranslatorPB and StorageContainerLocationProtocolServerSideTranslatorPB need throw exception to trigger FailoverProxyProvider of SCM client to work.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4542
How was this patch tested?
CI