Skip to content

Conversation

@elek
Copy link
Member

@elek elek commented Nov 30, 2020

What changes were proposed in this pull request?

There is an error log which can be seen frequently in the log:

2020-11-30 15:35:58,539 [CommandWatcher-LeaseManager#LeaseMonitor] ERROR lease.LeaseManager (LeaseManager.java:run(238)) - Execution was interrupted 
java.lang.InterruptedException: sleep interrupted
	at java.lang.Thread.sleep(Native Method)
	at org.apache.hadoop.ozone.lease.LeaseManager$LeaseMonitor.run(LeaseManager.java:234)
	at java.lang.Thread.run(Thread.java:748)

This log is introduced by HDDS-2561 to make Sonar happy, but it was not required as LeaseManager use the thread interrupt intentionally.

For a proper fix we can keep the logging on WARN level AND replace thread interrupts with thread notify/wait.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4526

How was this patch tested?

Unit test. TestLeaseManager has good coverage.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adoroszlai adoroszlai merged commit 9d9db48 into apache:master Dec 11, 2020
@adoroszlai
Copy link
Contributor

Thanks @elek for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants