HDDS-4505. Increase default value for SCM heartbeat timeout to 5s. #1634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokeshj1703
force-pushed
the
HDDS-4505
branch
from
368855a to
1079cc9
Compare
adoroszlai
reviewed
Dec 12, 2020
Contributor
There was a problem hiding this comment.
Thanks @lokeshj1703 for working on this. Default block deletion limit is still 10000, so I don't see why default heartbeat timeout should be increased. It can be configured by admins who change the limit manually. Maybe the description for block deletion limit config can mention how these settings are related.
nandakumar131
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
On increasing the block deletion limit for SCM from 10000 blocks per interval to 100000 blocks, the heartbeats were timing out in the datanodes. Current rpc timeout configured for SCM heartbeat is 1 second. The jira proposes to increase the rpc timeout to 5 seconds.
With 5 second configuration timeouts were not seen by the datanodes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4505
How was this patch tested?
Existing UT.