Skip to content

HDDS-4462. Add --frozen-lockfile to pnpm install to prevent ozone-recon-web/pnpm-lock.yaml from being updated automatically #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vivekratnavel merged 3 commits into from
Nov 17, 2020
Merged

HDDS-4462. Add --frozen-lockfile to pnpm install to prevent ozone-recon-web/pnpm-lock.yaml from being updated automatically #1589

vivekratnavel merged 3 commits into from
Nov 17, 2020

Conversation

@smengcl
Copy link
Contributor

@smengcl smengcl commented Nov 13, 2020 •
edited
Loading

Trivial fix.
Update ozone-recon-web/pnpm-lock.yaml as Git is reporting not clean after a maven build.

Add --frozen-lockfile to pnpm install to prevent ozone-recon-web/pnpm-lock.yaml from being updated automatically.

@smengcl
HDDS-4462. Update ozone-recon-web/pnpm-lock.yaml
666c9c9 
Change-Id: I052ae721069d25818df937ab75eec387f8cd905d
@smengcl smengcl self-assigned this Nov 13, 2020
@vivekratnavel
Copy link
Contributor

vivekratnavel commented Nov 14, 2020

This shouldn't be happening. I am curious to know which maven build command did you use?

@smengcl
Copy link
Contributor Author

smengcl commented Nov 15, 2020

This shouldn't be happening. I am curious to know which maven build command did you use?

mvn clean install -DskipTests -Dmaven.javadoc.skip

I found this issue on both my Mac and in a Ubuntu VM.

@vivekratnavel
Copy link
Contributor

vivekratnavel commented Nov 15, 2020

Thanks, @smengcl! I am unable to reproduce this lock file update on my machine.

Can you please try <arguments>pnpm install --frozen-lockfile</arguments> in https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/pom.xml#L121 ? You can then run the same mvn command inside hadoop-ozone/recon directory to build only recon and quickly test. Before the test, don't forget to checkout ozone-recon-web/pnpm-lock.yaml if there are any local changes. This time it should not update the lock file and your git tree should be clean. Please let me know the results. Thanks!

@smengcl
Copy link
Contributor Author

smengcl commented Nov 16, 2020

Thanks, @smengcl! I am unable to reproduce this lock file update on my machine.

Can you please try <arguments>pnpm install --frozen-lockfile</arguments> in https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/pom.xml#L121 ? You can then run the same mvn command inside hadoop-ozone/recon directory to build only recon and quickly test. Before the test, don't forget to checkout ozone-recon-web/pnpm-lock.yaml if there are any local changes. This time it should not update the lock file and your git tree should be clean. Please let me know the results. Thanks!

I tested that adding --frozen-lockfile to the argument works. ozone-recon-web/pnpm-lock.yaml is clean after the same mvn command.

I will change this jira to adding --frozen-lockfile instead.

@smengcl
Revert "HDDS-4462. Update ozone-recon-web/pnpm-lock.yaml"
08c924c 
This reverts commit 666c9c9.
@smengcl
HDDS-4462. Add --frozen-lockfile to pnpm install to prevent ozone-rec…
f201d81 
…on-web/pnpm-lock.yaml from being updated automatically

Change-Id: Ic99a28000faa1c33ea55ce3df58e5ed91fbf6011
@smengcl smengcl changed the title HDDS-4462. Update ozone-recon-web/pnpm-lock.yaml HDDS-4462. Add --frozen-lockfile to pnpm install to prevent ozone-recon-web/pnpm-lock.yaml from being updated automatically Nov 16, 2020
@vivekratnavel
Copy link
Contributor

vivekratnavel commented Nov 17, 2020

Thanks @smengcl! Patch looks good to me. +1

@vivekratnavel vivekratnavel merged commit 04a757a into apache:master Nov 17, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Nov 24, 2020
@errose28
Merge branch 'HDDS-3698-upgrade' into HDDS-4480
f259f39 
* HDDS-3698-upgrade: (46 commits)
  HDDS-4468. Fix Goofys listBucket large than 1000 objects will stuck forever (apache#1595)
  HDDS-4417. Simplify Ozone client code with configuration object -- addendum (apache#1581)
  HDDS-4476. Improve the ZH translation of the HA.md in doc. (apache#1597)
  HDDS-4432. Update Ratis version to latest snapshot. (apache#1586)
  HDDS-4488. Open RocksDB read only when loading containers at Datanode startup (apache#1605)
  HDDS-4478. Large deletedKeyset slows down OM via listStatus. (apache#1598)
  HDDS-4452. findbugs.sh couldn't be executed after a full build (apache#1576)
  HDDS-4427. Avoid ContainerCache in ContainerReader at Datanode startup (apache#1549)
  HDDS-4448. Duplicate refreshPipeline in listStatus (apache#1569)
  HDDS-4450. Cannot run ozone if HADOOP_HOME points to Hadoop install (apache#1572)
  HDDS-4346.Ozone specific Trash Policy (apache#1535)
  HDDS-4426. SCM should create transactions using all blocks received from OM (apache#1561)
  HDDS-4399. Safe mode rule for piplelines should only consider open pipelines. (apache#1526)
  HDDS-4367. Configuration for deletion service intervals should be different for OM, SCM and datanodes (apache#1573)
  HDDS-4462. Add --frozen-lockfile to pnpm install to prevent ozone-recon-web/pnpm-lock.yaml from being updated automatically (apache#1589)
  HDDS-4082. Create ZH translation of HA.md in doc. (apache#1591)
  HDDS-4464. Upgrade httpclient version due to CVE-2020-13956. (apache#1590)
  HDDS-4467. Acceptance test fails due to new Hadoop 3 image (apache#1594)
  HDDS-4466. Update url in .asf.yaml to use TLP project (apache#1592)
  HDDS-4458. Fix Max Transaction ID value in OM. (apache#1585)
  ...
errose28 added a commit to errose28/ozone that referenced this pull request Nov 25, 2020
@errose28
Merge branch 'HDDS-3698-upgrade' into HDDS-4463
8d38341 
* HDDS-3698-upgrade: (47 commits)
  HDDS-4468. Fix Goofys listBucket large than 1000 objects will stuck forever (apache#1595)
  HDDS-4417. Simplify Ozone client code with configuration object -- addendum (apache#1581)
  HDDS-4476. Improve the ZH translation of the HA.md in doc. (apache#1597)
  HDDS-4432. Update Ratis version to latest snapshot. (apache#1586)
  HDDS-4488. Open RocksDB read only when loading containers at Datanode startup (apache#1605)
  HDDS-4478. Large deletedKeyset slows down OM via listStatus. (apache#1598)
  HDDS-4452. findbugs.sh couldn't be executed after a full build (apache#1576)
  HDDS-4427. Avoid ContainerCache in ContainerReader at Datanode startup (apache#1549)
  HDDS-4448. Duplicate refreshPipeline in listStatus (apache#1569)
  HDDS-4450. Cannot run ozone if HADOOP_HOME points to Hadoop install (apache#1572)
  HDDS-4346.Ozone specific Trash Policy (apache#1535)
  HDDS-4426. SCM should create transactions using all blocks received from OM (apache#1561)
  HDDS-4399. Safe mode rule for piplelines should only consider open pipelines. (apache#1526)
  HDDS-4367. Configuration for deletion service intervals should be different for OM, SCM and datanodes (apache#1573)
  HDDS-4462. Add --frozen-lockfile to pnpm install to prevent ozone-recon-web/pnpm-lock.yaml from being updated automatically (apache#1589)
  HDDS-4082. Create ZH translation of HA.md in doc. (apache#1591)
  HDDS-4464. Upgrade httpclient version due to CVE-2020-13956. (apache#1590)
  HDDS-4467. Acceptance test fails due to new Hadoop 3 image (apache#1594)
  HDDS-4466. Update url in .asf.yaml to use TLP project (apache#1592)
  HDDS-4458. Fix Max Transaction ID value in OM. (apache#1585)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vivekratnavel vivekratnavel vivekratnavel approved these changes

Assignees

@smengcl smengcl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smengcl @vivekratnavel