HDDS-4434.Fix typo in Admin.md #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky76093016
force-pushed
the
HDDS-4434
branch
from
7377aee to
b60fd6f
Compare
sky76093016
force-pushed
the
HDDS-4434
branch
from
b60fd6f to
94d60ee
Compare
Member
|
Can you assign the jira to your name, or can you help me with your jira id, If you aren't able to do so. Would be great if you can put up a comment in the jira itself, I will pick the id from there |
Contributor
Author
|
@ayushtkn I have already replied in JIRA, thank you. |
cku328
approved these changes
Nov 7, 2020
Contributor
cku328
left a comment
cku328
left a comment
There was a problem hiding this comment.
LGTM+1. Thanks @sky76093016 for working on this.
Let's wait for full green build.
Member
|
Merged PR, Thanx @sky76093016 for the contribution and @cku328 for the review!!! |
Contributor
|
Thanks @ayushtkn for merging it. Should we modify Git commit message to make it look the same as the others? |
Member
|
That is ok. You can't change the commit message without reverting. And this commit will still stay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I corrected the spelling of the word.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4434
How was this patch tested?
No need.