Skip to content

Conversation

@elek
Copy link
Member

@elek elek commented Nov 2, 2020

What changes were proposed in this pull request?

Update README.md with the TLP information

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4416

How was this patch tested?

Text only change. 👀

Copy link
Contributor

@linyiqun linyiqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks for updating this.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elek for taking care of this.

Co-authored-by: Doroszlai, Attila <[email protected]>
Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @elek for the changes and others for the review.

@dineshchitlangia dineshchitlangia merged commit 08151fa into apache:master Nov 5, 2020
@cxorm
Copy link
Member

cxorm commented Nov 5, 2020

Hi @elek, thank you for updating this after TLP separation.

Would we change the line 80
cd hadoop-ozone/dist/target/ozone-*/compose/ozone
to
cd ozone/dist/target/ozone-*/compose/ozone ?

I think it is my nit, but, if yes
I propose we could also update the link and add new label on Github About Part : )
Github_AboutPart

@elek
Copy link
Member Author

elek commented Nov 16, 2020

Good findings @cxorm. Let me create a follow-up PR.

@elek
Copy link
Member Author

elek commented Nov 16, 2020

Would we change the line 80 cd hadoop-ozone/dist/target/ozone-*/compose/ozone to cd ozone/dist/target/ozone-*/compose/ozone ?

Project names are not (yet) changed. It's a bigger task:

  1. we can rename those hadoop- prefixes from the dir
  2. we can change package names
  3. we can update pom.xml descriptions.

But these are bigger tasks (imho)...

@cxorm
Copy link
Member

cxorm commented Nov 17, 2020

Good findings @cxorm. Let me create a follow-up PR.

Thank you @elek for the task : )

Project names are not (yet) changed. It's a bigger task:

  1. we can rename those hadoop- prefixes from the dir
  2. we can change package names
  3. we can update pom.xml descriptions.

But these are bigger tasks (imho)...

Yeah, thanks for the clarification, I also agree with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants