Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  1. Create a separate instance of FileSystem in HadoopFsGenerator for each test thread.
  2. Move directory creation to test setup. Previously mkdirs() resulted in an extra RPC for each file.
  3. Provide a hook method in BaseFreonGenerator for thread-specific cleanup.

https://issues.apache.org/jira/browse/HDDS-4313

How was this patch tested?

ozone freon ockg -n1 -t1 -p warmup
ozone freon dfsg -n10000 -t10
/opt/profiler/profiler.sh -e lock -d 60 -o svg -f dfsg-lock.svg $(ps aux | grep 'proc_freo[n]' | awk '{ print $2 }')

@adoroszlai adoroszlai self-assigned this Oct 6, 2020
@adoroszlai adoroszlai requested a review from elek October 7, 2020 04:15
@adoroszlai adoroszlai added enhancement New feature or request test labels Oct 7, 2020
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks for the patch @adoroszlai

Question: Is it reasonable to keep the original behavior (one client, multiple threads) or it's totally invalid?

@adoroszlai
Copy link
Contributor Author

Thanks @elek for the review.

Question: Is it reasonable to keep the original behavior (one client, multiple threads) or it's totally invalid?

I don't know. If you think it's worth the effort to add a flag to control this behavior, I can do that.

@adoroszlai adoroszlai merged commit 19dd94d into apache:master Dec 12, 2020
@adoroszlai adoroszlai deleted the HDDS-4313 branch December 12, 2020 09:32
@adoroszlai
Copy link
Contributor Author

Thanks @elek for the review.

Question: Is it reasonable to keep the original behavior (one client, multiple threads) or it's totally invalid?

I don't know. If you think it's worth the effort to add a flag to control this behavior, I can do that.

... if you create a follow-up Jira. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants