Skip to content

HDDS-4312. findbugs check succeeds despite compile error #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elek merged 3 commits into from
Oct 9, 2020
Merged

HDDS-4312. findbugs check succeeds despite compile error #1476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b168f3e
HDDS-4312. findbugs check succeeds despite failure
adoroszlai Oct 6, 2020
7b08c4a
HDDS-4312. Compile tests, too, for findbugs
adoroszlai Oct 6, 2020
27d8fcd
HDDS-4312. Protobuf generated classes in new interface-storage module…
adoroszlai Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions hadoop-ozone/dev-support/checks/findbugs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,13 @@ MAVEN_OPTIONS='-B -fae -Dskip.npx -Dskip.installnpx'

if ! type unionBugs >/dev/null 2>&1 || ! type convertXmlToText >/dev/null 2>&1; then
#shellcheck disable=SC2086
mvn ${MAVEN_OPTIONS} compile spotbugs:check
mvn ${MAVEN_OPTIONS} test-compile spotbugs:check
exit $?
fi

#shellcheck disable=SC2086
mvn ${MAVEN_OPTIONS} compile spotbugs:spotbugs
mvn ${MAVEN_OPTIONS} test-compile spotbugs:spotbugs
rc=$?

REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target/findbugs"}
mkdir -p "$REPORT_DIR"
Expand All @@ -42,3 +43,5 @@ wc -l "$REPORT_FILE" | awk '{print $1}'> "$REPORT_DIR/failures"
if [[ -s "${REPORT_FILE}" ]]; then
exit 1
fi

exit ${rc}
21 changes: 21 additions & 0 deletions hadoop-ozone/interface-storage/dev-support/findbugsExcludeFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<FindBugsFilter>
<Match>
<Package name="org.apache.hadoop.ozone.storage.proto"/>
</Match>
</FindBugsFilter>
9 changes: 8 additions & 1 deletion hadoop-ozone/interface-storage/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,13 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
</configuration>
</plugin>
</plugins>
</build>
</project>
</project>