HDDS-2464. Avoid unnecessary allocations for FileChannel.open call #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Test failures are not related to this change. |
nandakumar131
approved these changes
Nov 13, 2019
Contributor
Author
|
Thanks @nandakumar131 for reviewing and merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ChunkUtilscallsFileChannel#open(Path, OpenOption...). Vararg array elements are then added to a newHashSetto be passed toFileChannel#open(Path, Set<? extends OpenOption>, FileAttribute<?>...). We can call the latter directly instead.https://issues.apache.org/jira/browse/HDDS-2464
How was this patch tested?
Ran
TestChunkUtils.