Skip to content

Conversation

@elek
Copy link
Member

@elek elek commented Sep 29, 2020

What changes were proposed in this pull request?

Logo is too big on doc snapshot (generated by the Jenkins):

image

INFRA is migrated to a new jenkins and the new Jenkins adds a more secure HTTP headers:

< Content-Security-Policy: sandbox; default-src 'none'; img-src 'self'; style-src 'self';
< X-WebKit-CSP: sandbox; default-src 'none'; img-src 'self'; style-src 'self';

IMHO the inline styles which are used in the current code are disabled:

<a href="{{ "index.html" | relLangURL }}" class="navbar-left" style="height: 50px; padding: 5px 10px 5px 0px;">

While it's not a production issue, we can move the custom styles to the css, to make it compatible with the jenkins.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4288

How was this patch tested?

  1. If you remove inline style attributes , and do a hugo serve in hadoop-hdds/docs, you can see that the logo is too big.
  2. When you apply the patches (css based styles) the logo is fine, again.

It is supposed to be compatible with the Jenkins as all the other css based styles are working.

Copy link
Contributor

@vivekratnavel vivekratnavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@vivekratnavel
Copy link
Contributor

@elek Thanks for working on this! I noticed this weird big logo on the docs recently but didn't have the bandwidth to fix it.

@vivekratnavel vivekratnavel merged commit 2420ee8 into apache:master Sep 29, 2020
errose28 pushed a commit to errose28/ozone that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants