Skip to content

HDDS-4234. Add important comment to ListVolumes logic #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elek merged 3 commits into from
Sep 23, 2020
Merged

HDDS-4234. Add important comment to ListVolumes logic #1417

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf01342
HDDS-4324. Add importent comment to ListVolumets logic
Sep 11, 2020
5e0009a
fix checkstyle error
Sep 11, 2020
daf4b2d
fix checkstyle error
Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/ObjectStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,9 @@ private class VolumeIterator implements Iterator<OzoneVolume> {

@Override
public boolean hasNext() {
// IMPORTANT: Without this logic, remote iteration will not work.
// Removing this will break the listVolume call if we try to
// list more than 1000 (ozone.client.list.cache ) volumes.
if (!currentIterator.hasNext() && currentValue != null) {
currentIterator = getNextListOfVolumes(currentValue.getName())
.iterator();
Expand Down