HDDS-4158. Provide a class type for Java based configuration #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@adoroszlai Please take a look at this PR, it will help us to use the |
adoroszlai
approved these changes
Sep 29, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @maobaolong for this improvement, looks good to me. I suggested a small change to get rid of a warning. Sorry for the late response.
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/conf/SimpleConfiguration.java
Outdated
Show resolved
Hide resolved
…impleConfiguration.java Co-authored-by: Doroszlai, Attila <[email protected]>
elek
approved these changes
Oct 5, 2020
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1 LGTM
Thanks the patch @maobaolong Will merge it after the green build.
Member
Author
|
Thank @elek for trigger ci checks for me, now it getting green, could you please to merge this PR? |
Contributor
|
Thanks @maobaolong for the improvement and @elek for the review. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Oct 19, 2020
* master: HDDS-4301. SCM CA certificate does not encode KeyUsage extension properly (apache#1468) HDDS-4158. Provide a class type for Java based configuration (apache#1407) HDDS-4297. Allow multiple transactions per container to be sent for deletion by SCM. HDDS-2922. Balance ratis leader distribution in datanodes (apache#1371) HDDS-4269. Ozone DataNode thinks a volume is failed if an unexpected file is in the HDDS root directory. (apache#1490) HDDS-4327. Potential resource leakage using BatchOperation. (apache#1493) HDDS-3995. Fix s3g met NPE exception while write file by multiPartUpload (apache#1499) HDDS-4343. ReplicationManager.handleOverReplicatedContainer() does not handle unhealthyReplicas properly. (apache#1495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provide a class type for Java based configuration
What is the link to the Apache JIRA
HDDS-4158
How was this patch tested?
The related unit test can prove this work as expected.