Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Use explicit base image version ($OZONE_RUNNER_VERSION) instead of implicit latest for images derived from ozone-runner (in ozone-om-ha and ozonescripts compose environments). Also tag the resulting image with the same version instead of implicit latest. The goal is to force rebuild of these images if a new ozone-runner image is released (and docker.ozone-runner.version updated in hadoop-ozone/dist/pom.xml).

https://issues.apache.org/jira/browse/HDDS-2456

How was this patch tested?

$ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts
$ docker-compose up -d
Creating network "ozonescripts_default" with the default driver
Building datanode
Step 1/16 : ARG OZONE_RUNNER_VERSION
Step 2/16 : FROM apache/ozone-runner:${OZONE_RUNNER_VERSION}
20191107-1: Pulling from apache/ozone-runner
Digest: sha256:185e18663394e1976d73a6f7de2aa8ade4d20a0e7314b415cad6f26f446323fe
Status: Downloaded newer image for apache/ozone-runner:20191107-1
...

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 works well. Thanks the patch @adoroszlai

@elek elek closed this in 1c1aecf Nov 12, 2019
@adoroszlai adoroszlai deleted the HDDS-2456 branch November 12, 2019 16:26
@adoroszlai
Copy link
Contributor Author

Thanks @elek for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants