HDDS-2417 Add the list trash command to the client side #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/retest |
anuengineer
approved these changes
Nov 10, 2019
Contributor
There was a problem hiding this comment.
I think we need to add OMUtils#isReadOnly function. I think we should add this command as a read only command to that function.
The Unit test failure is related to that.
Otherwise the patch looks excellent, and as soon as we fix it I will get it committed. Thanks
Contributor
There was a problem hiding this comment.
As a future JIRA, I was thinking it might be useful to get just the list of buckets that are deleted. It might be interesting.
dineshchitlangia
approved these changes
Nov 11, 2019
Contributor
dineshchitlangia
left a comment
dineshchitlangia
left a comment
There was a problem hiding this comment.
+1 LGTM.
Integration failure is unrelated.
Although it says Acceptance finished with failed status, however, I see all tests in acceptance have passed.
Contributor
|
@mbsharp Thank you for the contribution and thanks @anuengineer for the reviews. |
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
…in Recon UI. (apache#7149) (apache#138) (cherry picked from commit 4b47812) Co-authored-by: Arafat2198 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the first commit for a new trash feature for Ozone. This PR tackles adding client side changes to support a list trash command which will show deleted keys from the deleted keys tables.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2417
How was this patch tested?
New tests will be added as this is built out further with the core logic. For the initial changes in this PR, check style and local mvn build passed.