Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Intermittent failure in testDeleteKeyWithSlowFollower seems to be caused by:

  • DeleteBlocksCommandHandler increments invocationCount near the beginning of handle(), and only updates deleteTransactionId later
  • TestDeleteWithSlowFollower waits for invocationCount >= 1, then asserts deleteTransactionId also increased

The test is fixed by changing the order in the handler: only increment invocationCount at the end, when deleteTransactionId is already updated.

I think invocationCount should be updated together with totalTime to provide (slightly more) correct average run time (getAverageRunTime).

https://issues.apache.org/jira/browse/HDDS-3762

How was this patch tested?

Passed 50x:
https://github.com/adoroszlai/hadoop-ozone/runs/1059570465#step:5:4

Regular CI:
https://github.com/adoroszlai/hadoop-ozone/runs/1059560880

@adoroszlai adoroszlai self-assigned this Sep 2, 2020
@bshashikant bshashikant merged commit 79f9fab into apache:master Sep 3, 2020
@bshashikant
Copy link
Contributor

Thanks @adoroszlai for the contribution.

rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
@adoroszlai adoroszlai deleted the HDDS-3762 branch September 3, 2020 11:40
@adoroszlai
Copy link
Contributor Author

Thanks @bshashikant for reviewing and committing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants