HDDS-3762. Intermittent failure in TestDeleteWithSlowFollower #1376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Intermittent failure in
testDeleteKeyWithSlowFollowerseems to be caused by:DeleteBlocksCommandHandlerincrementsinvocationCountnear the beginning ofhandle(), and only updatesdeleteTransactionIdlaterTestDeleteWithSlowFollowerwaits forinvocationCount >= 1, then assertsdeleteTransactionIdalso increasedThe test is fixed by changing the order in the handler: only increment
invocationCountat the end, whendeleteTransactionIdis already updated.I think
invocationCountshould be updated together withtotalTimeto provide (slightly more) correct average run time (getAverageRunTime).https://issues.apache.org/jira/browse/HDDS-3762
How was this patch tested?
Passed 50x:
https://github.com/adoroszlai/hadoop-ozone/runs/1059570465#step:5:4
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/runs/1059560880