-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-4189. Change ozone admin om getserviceroles to ozone admin om roles
#1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Context: #1346 (comment) |
cxorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amaliujia for the work.
This modification looks good to me.
|
Thank you for your review @cxorm! The failed UT seems not related to this change. |
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amaliujia for working on this. Can you please add an alias to avoid breaking any existing scripts that might use this command?
...op-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/GetServiceRolesSubcommand.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Doroszlai, Attila <[email protected]>
|
It seemed that there is another opinion about what command name should be. So I will convert this PR to a draft now to wait for a consensus. Thanks for all reviews so far and sorry for the confusion. |
ozone admin om getserviceroles to ozone admin om statusozone admin om getserviceroles to ozone admin om roles
|
Ok finally I think we can use I made necessary change in this PR. Can you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amaliujia for this improvement and @cxorm for the review.
What changes were proposed in this pull request?
Change
ozone admin om getservicerolestoozone admin om rolesWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4189
How was this patch tested?
Unit Test