HDDS-4165. GitHub Actions cache does not work outside of workspace #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekratnavel
approved these changes
Sep 2, 2020
Contributor
|
@adoroszlai Thanks for fixing this! +1 LGTM |
elek
approved these changes
Sep 2, 2020
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1 LGTM, thanks to fix (and thanks the review @vivekratnavel)
I have a strange feeling that we do an additional checkout just to hash pom.xml but I have no better idea ;-)
Contributor
Author
|
Thanks @vivekratnavel for the review, and @elek for reviewing and committing it. |
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Checkout project to its regular location (inside
GITHUB_WORKSPACE) before attempting to restore cache. This allows calculation of hash of cache key files (pom.xml,pnpm-lock.yaml)https://issues.apache.org/jira/browse/HDDS-4165
How was this patch tested?
Verified that cache key now includes hash of files:
https://github.com/adoroszlai/hadoop-ozone/runs/1042731167#step:3:5
https://github.com/adoroszlai/hadoop-ozone/runs/1042730953#step:4:9
and subsequent build on same branch reuses cache:
https://github.com/adoroszlai/hadoop-ozone/runs/1042919167#step:3:10
https://github.com/adoroszlai/hadoop-ozone/runs/1042919016#step:4:13