HDDS-4161. Set fs.defaultFS in docker compose cluster config to OFS #1362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I06f1568e821b2d8b902a3c4d20d3c92372e4976d
adoroszlai
approved these changes
Aug 28, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @smengcl for extracting this change to a separate PR. LGTM.
FYI, there are two cases where O3FS is still the default:
hadoop-ozone/dist/src/main/compose/ozone-mr/common-config
33:CORE-SITE.xml_fs.defaultFS=o3fs://bucket1.volume1/
hadoop-ozone/dist/src/main/compose/ozone-ha/docker-config
17:CORE-SITE.XML_fs.defaultFS=o3fs://bucket1.volume1.omservice
The first one is used by tests, the second one is disabled currently.
Contributor
Author
Good catch @adoroszlai . I have updated the PR. |
llemec
pushed a commit
to llemec/hadoop-ozone
that referenced
this pull request
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set fs.defaultFS in docker compose cluster config to OFS by default.
This shouldn't impact any existing tests. This makes life easier when developer manually logs into the cluster and use hadoop fs commands. e.g. ozone fs -ls / can easily list all volumes in the test cluster with OFS.
Previous discussion at #1352 (comment)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4161
How was this patch tested?
This change should only affect the robot test infra.
All existing tests (including robot tests) should pass as-is.