Skip to content

Conversation

@bharatviswa504
Copy link
Contributor

@bharatviswa504 bharatviswa504 commented Aug 13, 2020

What changes were proposed in this pull request?

Normalize Keypath for listKeys.
When ozone.om.enable.filesystem.paths, OM normalizes path, and stores the Keyname in the OM DB KeyTable.

When listKeys uses given keyName(not normalized key path) as prefix and Starkey the list-keys will return an empty results.

Similar to HDDS-4102, we should normalize Starkey and keyPrefix.

Note:
This PR is based on top of #1328
To get CI, posted a PR with both fixes included.
The changes for this commit start from ab0cee5

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4117

How was this patch tested?

Added a test.

@bharatviswa504 bharatviswa504 changed the title HDDS-4117. HDDS-4117. Normalize Keypath for listKeys. Aug 13, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1331 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1331      +/-   ##
============================================
- Coverage     74.41%   74.35%   -0.07%     
- Complexity    10301    10324      +23     
============================================
  Files           984      985       +1     
  Lines         50394    50549     +155     
  Branches       4914     4937      +23     
============================================
+ Hits          37503    37587      +84     
- Misses        10531    10600      +69     
- Partials       2360     2362       +2     
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/apache/hadoop/ozone/OmUtils.java 80.66% <100.00%> (+1.08%) 49.00 <3.00> (+3.00)
...ava/org/apache/hadoop/ozone/om/KeyManagerImpl.java 65.34% <100.00%> (+0.43%) 140.00 <4.00> (+4.00)
...pache/hadoop/ozone/om/request/OMClientRequest.java 81.17% <100.00%> (-1.25%) 29.00 <1.00> (-2.00)
...hdds/scm/container/common/helpers/ExcludeList.java 78.26% <0.00%> (-21.74%) 17.00% <0.00%> (-5.00%)
...doop/ozone/om/exceptions/OMNotLeaderException.java 48.48% <0.00%> (-18.19%) 3.00% <0.00%> (-2.00%)
.../apache/hadoop/hdds/scm/node/StaleNodeHandler.java 88.88% <0.00%> (-11.12%) 4.00% <0.00%> (ø%)
...e/hadoop/ozone/recon/tasks/OMDBUpdatesHandler.java 60.93% <0.00%> (-9.66%) 9.00% <0.00%> (-8.00%)
...ache/hadoop/ozone/om/codec/S3SecretValueCodec.java 90.90% <0.00%> (-9.10%) 3.00% <0.00%> (-1.00%)
...va/org/apache/hadoop/hdds/utils/db/RDBMetrics.java 92.85% <0.00%> (-7.15%) 14.00% <0.00%> (-1.00%)
...ozone/container/ozoneimpl/ContainerController.java 76.31% <0.00%> (-5.27%) 13.00% <0.00%> (-1.00%)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c22180...d9bbc1e. Read the comment docs.

@elek elek changed the title HDDS-4117. Normalize Keypath for listKeys. HDDS-4117. Normalize Keypath for listKeys. Aug 25, 2020
@bharatviswa504
Copy link
Contributor Author

Closing this. Opened #1451 to track this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants