HDDS-1889. Add support for verifying multiline log entry #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @llemec, thank you for the contribution, the test looks good to me, thank you for addressing my concerns from the previous PR ;) I am +1 on this, let a commiter as well review and commit the changes if he/she does not have any further concerns ;) |
adoroszlai
requested changes
Aug 10, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @llemec for working on this.
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Aug 11, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @llemec for updating the patch.
elek
changed the title
Contributor
|
@dineshchitlangia would you like to review this audit log test improvement? |
dineshchitlangia
approved these changes
Sep 3, 2020
Contributor
dineshchitlangia
left a comment
dineshchitlangia
left a comment
There was a problem hiding this comment.
+1 LGTM.
Thanks @llemec for the contribution, @fapifta and @adoroszlai for the reviews.
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added multi line support for Audit messages in TestOzoneAuditLogger
Added hamcrest in testing scope to allow for more legible testing
This PR is a re-submit of the now cancelled #1293, as the git branch got tangled up.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-1889
How was this patch tested?
added messageIncludesMultilineException in TestOzoneAuditLogger