Skip to content

Conversation

@bharatviswa504
Copy link
Contributor

@bharatviswa504 bharatviswa504 commented Nov 7, 2019

What changes were proposed in this pull request?

Exclude web apps from filesystem uber jar.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2427

How was this patch tested?

This has caused Hadoop HDFS DN UI loading, now with placing the fixed jar UI is able to load up.

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @bharatviswa504 the quick fix

It solves the problem quickly, but as a long-term solution we need to review the dependency graph. None of the server side components should be available from the client jar. As I see the framework (=server side common) and container service jar files are added to the ozonefs, which is bad.

But we can fix it in a separated jira as it may require more time.

@elek
Copy link
Member

elek commented Nov 8, 2019

Tested with unzip -l target/hadoop-ozone-filesystem-lib-current-0.5.0-SNAPSHOT.jar | grep webapp. Webapp has been disappeared.

@elek elek closed this in 6a450fb Nov 8, 2019
@elek
Copy link
Member

elek commented Nov 8, 2019

Dependency cleanup has been uploaded as #130

@bharatviswa504
Copy link
Contributor Author

+1 Thanks @bharatviswa504 the quick fix

It solves the problem quickly, but as a long-term solution we need to review the dependency graph. None of the server side components should be available from the client jar. As I see the framework (=server side common) and container service jar files are added to the ozonefs, which is bad.

But we can fix it in a separated jira as it may require more time.

Yes, you are 100% right. I will have a look into #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants