HDDS-2415. Completely disable tracer if hdds.tracing.enabled=false #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
elek
approved these changes
Nov 12, 2019
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1 LGTM Thanks the patch @adoroszlai
Tested with ozoneperf, the tracing still works well.
Contributor
Author
|
Thanks @elek for reviewing and committing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Skip registering a real tracer with
GlobalTracerifhdds.tracing.enabledis set tofalse. This lets us avoid tracer-related busywork.https://issues.apache.org/jira/browse/HDDS-2415
How was this patch tested?
ozoneperfcluster with default config, verified that it shows traces (OM, SCM, DN, Freon, S3 shell, Ozone shell)OZONE-SITE.XML_hdds.tracing.enabled=falseadded todocker-config, verified that Jaeger shows no tracesozonecluster, verified thatGlobalTracerno longer shows up in breakdown of allocations fromHddsDispatcher.dispatchin the profiler