HDDS-4035. Update logs of HadoopDirGenerator. #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshadr
reviewed
Jul 29, 2020
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HadoopNestedDirGenerator.java
Outdated
Show resolved
Hide resolved
aryangupta1998
changed the title
rakeshadr
reviewed
Jul 30, 2020
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HadoopDirTreeGenerator.java
Outdated
Show resolved
Hide resolved
…ator - Fixed minor changes.
rakeshadr
reviewed
Jul 30, 2020
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
Outdated
Show resolved
Hide resolved
…ator - Fixed Javadoc.
xiaoyuyao
reviewed
Jul 31, 2020
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
Jul 31, 2020
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
LGTM overall, just one minor suggestion added inline
Contributor
|
@aryangupta1998, Thanks for updating the PR! The changes look good to me. Pending GREEN CI |
Contributor
|
Merged the changes to master branch. Thanks @aryangupta1998 for the contribution! |
llemec
pushed a commit
to llemec/hadoop-ozone
that referenced
this pull request
Aug 7, 2020
vivekratnavel
pushed a commit
to vivekratnavel/hadoop-ozone
that referenced
this pull request
Aug 8, 2020
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added logs to HadoopNestedDirGenerator.
Edit logs of HadoopDirTreeGenerator.
Use BaseFreonGenerator printReport() for shell and command-line execution of freon commands like ddsg, dtsg, etc.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4035
How was this patch tested?
Tested Manually.