HDDS-2410. Ozoneperf docker cluster should use privileged containers #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
Nov 7, 2019
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @elek for this improvement, it works fine.
bharatviswa504
approved these changes
Nov 8, 2019
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
+1 LGTM.
Thank You @adoroszlai for the review and @elek for the contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The profiler servlet (which helps to run java profiler in the background and publishes the result on the web interface) requires privileged docker containers.
This flag is missing from the ozoneperf docker-compose cluster (which is designed to run performance tests).
What is the link to the Apache JIRA
https://github.com/elek/hadoop-ozone/pull/new/HDDS-2410
How was this patch tested?
firefox http://localhost:9876/prof
Execute the proposed kernel parameter adjustments:
Reponed http://localhost:9876/prof
After 10 seconds you should see the profiler flame graph