HDDS-3995. Fix s3g met NPE exception while write file by multiPartUpload #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5f5af8b.
2) fix npm proxy issue
adoroszlai
requested changes
Jul 21, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @maobaolong the fix.
You mentioned that this started happening after upgrading s3g to HDDS-3350. Can you please explain how that change triggered this NPE? Or was it a previous change, and if so, which one?
Send a put request with an uploadId.
Can you please add a test case in hadoop-ozone/dist/src/main/smoketest/s3 for this?
Member
Author
|
@adoroszlai The HDDS-3994 is triggered by HDDS-3350, about this one, maybe no relation with HDDS-3350. |
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@GlenGeng @bharatviswa504 Thanks for your suggestion, I push a new commit to fix this. PTAL |
Contributor
|
+1, LGTM. |
bharatviswa504
requested changes
Oct 14, 2020
|
|
||
| @staticmethod | ||
| def iter_n(iterable, n, fillvalue=None): | ||
| args = [iter(iterable)] * n |
Contributor
There was a problem hiding this comment.
Are these changes related to this PR? It has files named under directory Tencent.
Contributor
|
Closing this, it is committed thru #1499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix s3g met NPE exception while write file by multiPartUpload
What is the link to the Apache JIRA
HDDS-3995
How was this patch tested?
Send a put request with an uploadId.