-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-3989. Display revision and build date of DN in recon UI #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vivekratnavel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM pending CI checks
|
/retest |
|
No such command.
|
|
//retest |
|
No such command.
|
|
/help |
|
Available commands:
|
|
/retest |
|
To re-run CI checks, please follow these steps with the source branch checked out: |
trigger CI again |
|
@vivekratnavel Since the CI passed, can we merge this PR. Thanks. |
|
@runitao Thanks for working on this! |
|
Hi, thanks for the contributions @runitao, it's very useful for the UI. It looked good to me, but when I analyzed the network traffic found that the two new fields are added two all the requests as the DatanodeInfo protocol is a shared type. For example when I do |
|
@elek Good catch! I have created a jira to track this - https://issues.apache.org/jira/browse/HDDS-4039 |
|
Thanks for your suggestion @elek. And thank you for assigning HDDS-4039 to me, @vivekratnavel, I will fix that. |
What changes were proposed in this pull request?
People can get more detailed version info about DN in recon UI.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3989
How was this patch tested?
Test in docker-compose environment

Test in

pnpm run devand code is linted withyarn run lint:fix