Skip to content

Conversation

@runitao
Copy link
Contributor

@runitao runitao commented Jul 20, 2020

What changes were proposed in this pull request?

People can get more detailed version info about DN in recon UI.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3989

How was this patch tested?

Test in docker-compose environment
image

Test in pnpm run dev and code is linted with yarn run lint:fix
image

Copy link
Contributor

@vivekratnavel vivekratnavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM pending CI checks

@vivekratnavel
Copy link
Contributor

/retest

@github-actions
Copy link

No such command. retest Available commands:

  • /close : Close pending pull request temporary
  • /help : Show all the available comment commands
  • /label : add new label to the issue: /label <label>
  • /pending : Add a REQUESTED_CHANGE type review to mark issue non-mergeable: /pending <reason>
  • /ready : Dismiss all the blocking reviews by github-actions bot
  • /retest : provide help on how to trigger new CI build

@vivekratnavel
Copy link
Contributor

//retest

@github-actions
Copy link

No such command. /retest Available commands:

  • /close : Close pending pull request temporary
  • /help : Show all the available comment commands
  • /label : add new label to the issue: /label <label>
  • /pending : Add a REQUESTED_CHANGE type review to mark issue non-mergeable: /pending <reason>
  • /ready : Dismiss all the blocking reviews by github-actions bot
  • /retest : provide help on how to trigger new CI build

@runitao
Copy link
Contributor Author

runitao commented Jul 21, 2020

/help

@github-actions
Copy link

Available commands:

  • /close : Close pending pull request temporary
  • /help : Show all the available comment commands
  • /label : add new label to the issue: /label <label>
  • /pending : Add a REQUESTED_CHANGE type review to mark issue non-mergeable: /pending <reason>
  • /ready : Dismiss all the blocking reviews by github-actions bot
  • /retest : provide help on how to trigger new CI build

@runitao
Copy link
Contributor Author

runitao commented Jul 21, 2020

/retest

@github-actions
Copy link

To re-run CI checks, please follow these steps with the source branch checked out:

git commit --allow-empty -m 'trigger new CI check'
git push

@runitao
Copy link
Contributor Author

runitao commented Jul 21, 2020

Log:     /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/upgrade/result/log.html
Report:  /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/upgrade/result/report.html
cp: cannot stat '/mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/upgrade/result/*.out*': No such file or directory
Log:     /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/result/log.html
Report:  /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/result/report.html
Exception in thread "main" 
##[error]Process completed with exit code 1.

trigger CI again

@runitao
Copy link
Contributor Author

runitao commented Jul 21, 2020

@vivekratnavel Since the CI passed, can we merge this PR. Thanks.

@vivekratnavel vivekratnavel merged commit 76a9883 into apache:master Jul 21, 2020
@vivekratnavel
Copy link
Contributor

@runitao Thanks for working on this!

@elek
Copy link
Member

elek commented Jul 24, 2020

Hi, thanks for the contributions @runitao, it's very useful for the UI.

It looked good to me, but when I analyzed the network traffic found that the two new fields are added two all the requests as the DatanodeInfo protocol is a shared type.

For example when I do createKey or block allocations the new fields are added. Which means that the performance is worse in case of many small keys. I think it can be better to further improve it and add the fields only to the SCM registration type.

@vivekratnavel
Copy link
Contributor

@elek Good catch! I have created a jira to track this - https://issues.apache.org/jira/browse/HDDS-4039

@runitao
Copy link
Contributor Author

runitao commented Jul 28, 2020

Thanks for your suggestion @elek. And thank you for assigning HDDS-4039 to me, @vivekratnavel, I will fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants