Skip to content

HDDS-3984. Support filter and search the columns in recon UI #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vivekratnavel merged 3 commits into from
Jul 20, 2020
Merged

HDDS-3984. Support filter and search the columns in recon UI #1218

vivekratnavel merged 3 commits into from
Jul 20, 2020

Conversation

@runitao
Copy link
Contributor

@runitao runitao commented Jul 18, 2020

What changes were proposed in this pull request?

Add the functions of filter and search in recon UI. People can filter/search the columns.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3984

How was this patch tested?

lint with yarn run lint:fix
test with pnpm run dev

This picture show how filter work.
image

And this picture show how search work.
image

@vivekratnavel vivekratnavel self-requested a review July 18, 2020 19:16
vivekratnavel
vivekratnavel requested changes Jul 18, 2020
View reviewed changes
@vivekratnavel
Copy link
Contributor

vivekratnavel commented Jul 18, 2020

@runitao Thanks for working on this! I tested your changes locally and it looks good.

@runitao
Copy link
Contributor Author

runitao commented Jul 19, 2020

@vivekratnavel Thanks for your awesome suggestions. PTAL again, thanks.

@runitao
Copy link
Contributor Author

runitao commented Jul 20, 2020 

[ERROR] Failures: 
[ERROR]   TestCommitWatcher.testReleaseBuffersOnException:320
[ERROR] Errors: 
[ERROR]   TestWatchForCommit.testWatchForCommitForGroupMismatchException:344 ? IO bffb5f...

and

Removing network upgrade_net
Log:     /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/upgrade/result/log.html
Report:  /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/upgrade/result/report.html
cp: cannot stat '/mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/upgrade/result/*.out*': No such file or directory
Log:     /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/result/log.html
Report:  /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/result/report.html
Exception in thread "main" java.net.SocketException: Socket closed
	at java.net.PlainSocketImpl.socketAccept(Native Method)
	at java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:409)
	at java.net.ServerSocket.implAccept(ServerSocket.java:560)
	at java.net.ServerSocket.accept(ServerSocket.java:528)
	at org.apache.hadoop.test.JacocoServer.main(JacocoServer.java:60)
##[error]Process completed with exit code 1.

I think these two fails are unrelated with this PR.
Could help me trigger CI again, @adoroszlai，Thanks.

@adoroszlai
Copy link
Contributor

adoroszlai commented Jul 20, 2020

Could help me trigger CI again, @adoroszlai，Thanks.

Done. (You can also try /retest next time, which should provide instructions on how to trigger CI.)

@runitao
Copy link
Contributor Author

runitao commented Jul 20, 2020

@adoroszlai Thanks, I got it.

vivekratnavel
vivekratnavel approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@vivekratnavel vivekratnavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@vivekratnavel vivekratnavel merged commit caf4711 into apache:master Jul 20, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Jul 20, 2020
@errose28
Merge branch 'master' into HDDS-3869
af8b4d4 
* master:
  HDDS-3984. Support filter and search the columns in recon UI (apache#1218)
  HDDS-3806. Support recognize aws v2 Authorization header. (apache#1098)
  HDDS-3955. Unable to list intermediate paths on keys created using S3G. (apache#1196)
  HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (apache#1129)
  HDDS-3965. SCM failed to start up for duplicated pipeline detected. (apache#1210)
  HDDS-3855. Add upgrade smoketest (apache#1142)
  HDDS-3964. Ratis config key mismatch (apache#1204)
  HDDS-3612. Allow mounting bucket under other volume (apache#1104)
  HDDS-3926. OM Token Identifier table should use in-house serialization. (apache#1182)
  HDDS-3824: OM read requests should make SCM#refreshPipeline outside BUCKET_LOCK (apache#1164)
  HDDS-3966. Disable flaky TestOMRatisSnapshots
errose28 added a commit to errose28/ozone that referenced this pull request Jul 20, 2020
@errose28
Merge branch 'HDDS-3869' into switch-to-new-interface
cf6e0c4 
* HDDS-3869:
  HDDS-3984. Support filter and search the columns in recon UI (apache#1218)
  HDDS-3806. Support recognize aws v2 Authorization header. (apache#1098)
  HDDS-3955. Unable to list intermediate paths on keys created using S3G. (apache#1196)
  HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (apache#1129)
  HDDS-3965. SCM failed to start up for duplicated pipeline detected. (apache#1210)
errose28 added a commit to errose28/ozone that referenced this pull request Jul 20, 2020
@errose28
Merge branch 'master' into HDDS-3976
18f6a18 
* master:
  HDDS-3984. Support filter and search the columns in recon UI (apache#1218)
  HDDS-3806. Support recognize aws v2 Authorization header. (apache#1098)
  HDDS-3955. Unable to list intermediate paths on keys created using S3G. (apache#1196)
  HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (apache#1129)
  HDDS-3965. SCM failed to start up for duplicated pipeline detected. (apache#1210)
errose28 pushed a commit to errose28/ozone that referenced this pull request Jul 21, 2020
@runitao @errose28
HDDS-3984. Support filter and search the columns in recon UI (apache#…
8517e38 
…1218)
errose28 added a commit to errose28/ozone that referenced this pull request Jul 21, 2020
@errose28
Merge branch 'add-deleted-block-table' into HDDS-3869
2fa068b 
* add-deleted-block-table: (63 commits)
  Make block iterator tests use deleted blocks table, and remove the now unused #deleted#
  Replace uses of #deleted# key prefix with access to new deleted blocks table
  Add deleted blocks table to base level DB wrappers
  Have block deleting service test look for #deleted# keys in metadata table
  Move block delete to correct table and remove debugging print statement
  Import schema version when importing container data from export
  HDDS-3984. Support filter and search the columns in recon UI (apache#1218)
  HDDS-3806. Support recognize aws v2 Authorization header. (apache#1098)
  HDDS-3955. Unable to list intermediate paths on keys created using S3G. (apache#1196)
  HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (apache#1129)
  Move new key value block iterator implementation and tests to new interface
  Fix checkstyle violations
  HDDS-3965. SCM failed to start up for duplicated pipeline detected. (apache#1210)
  Update comments
  Add comments on added helper method
  Remove seekToLast() from iterator interface, implementation, and tests
  Add more robust unit test with alternating key matches
  All unit tests pass after allowing keys with deleted and deleting prefixes to be made
  HDDS-3855. Add upgrade smoketest (apache#1142)
  HDDS-3964. Ratis config key mismatch (apache#1204)
  ...
timmylicheng pushed a commit that referenced this pull request Aug 6, 2020
@runitao @timmylicheng
HDDS-3984. Support filter and search the columns in recon UI (#1218)
23dafc5
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
@runitao @rakeshadr
HDDS-3984. Support filter and search the columns in recon UI (apache#…
dd16443 
…1218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vivekratnavel vivekratnavel vivekratnavel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@runitao @vivekratnavel @adoroszlai