Skip to content

HDDS-3981. Add more debug level log to XceiverClientGrpc for debug purpose #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoyuyao merged 8 commits into from
Sep 17, 2020
Merged

HDDS-3981. Add more debug level log to XceiverClientGrpc for debug purpose #1214

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0729631
HDDS-3981. Add more debug level log to XceiverClientGrpc for debug pu…
maobaolong Jul 17, 2020
39a4825
trigger new ci check
maobaolong Jul 18, 2020
a49773e
trigger new ci check
maobaolong Jul 18, 2020
e1d7e9a
trigger new ci check
maobaolong Jul 18, 2020
9e13176
trigger new ci check
maobaolong Jul 22, 2020
6a3d7b3
trigger new ci check
maobaolong Jul 22, 2020
6a7a413
Address comments, log the ip address o dn only.
maobaolong Aug 10, 2020
0f027d8
Address comment, move the debug log into sendCommandAsync
maobaolong Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ private XceiverClientReply sendCommandWithRetry(
responseProto = null;
} catch (ExecutionException e) {
LOG.debug("Failed to execute command {} on datanode {}",
request, dn.getUuid(), e);
request, dn, e);
if (Status.fromThrowable(e.getCause()).getCode()
== Status.UNAUTHENTICATED.getCode()) {
throw new SCMSecurityException("Failed to authenticate with "
Expand Down Expand Up @@ -433,7 +433,7 @@ public XceiverClientReply sendCommandAsync(
UUID dnId = dn.getUuid();
if (LOG.isDebugEnabled()) {
LOG.debug("Send command {} to datanode {}",
request.getCmdType(), dn.getNetworkFullPath());
request.getCmdType(), dn.getIpAddress());
}
final CompletableFuture<ContainerCommandResponseProto> replyFuture =
new CompletableFuture<>();
Expand All @@ -452,17 +452,29 @@ public XceiverClientReply sendCommandAsync(
public void onNext(ContainerCommandResponseProto value) {
replyFuture.complete(value);
metrics.decrPendingContainerOpsMetrics(request.getCmdType());
long cost = System.nanoTime() - requestTime;
metrics.addContainerOpsLatency(request.getCmdType(),
System.nanoTime() - requestTime);
cost);
if (LOG.isDebugEnabled()) {
LOG.debug("Executed command {} on datanode {}, cost = {}, "
+ "cmdType = {}", request, dn,
cost, request.getCmdType());
}
semaphore.release();
}

@Override
public void onError(Throwable t) {
replyFuture.completeExceptionally(t);
metrics.decrPendingContainerOpsMetrics(request.getCmdType());
long cost = System.nanoTime() - requestTime;
metrics.addContainerOpsLatency(request.getCmdType(),
System.nanoTime() - requestTime);
if (LOG.isDebugEnabled()) {
LOG.debug("Executed command {} on datanode {}, cost = {}, "
+ "cmdType = {}", request, dn,
cost, request.getCmdType());
}
semaphore.release();
}

Expand Down