HDDS-3960. Display more accurate timestamp in recon Web #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekratnavel
requested changes
Jul 15, 2020
Contributor
vivekratnavel
left a comment
vivekratnavel
left a comment
There was a problem hiding this comment.
Overall LGTM except for the timestamp format.
| sorter: (a: IDatanode, b: IDatanode) => a.lastHeartbeat - b.lastHeartbeat, | ||
| render: (heartbeat: number) => { | ||
| return heartbeat > 0 ? moment(heartbeat).format('lll') : 'NA'; | ||
| return heartbeat > 0 ? moment(heartbeat).format('YYYY/MM/DD HH:mm:ss') : 'NA'; |
Contributor
There was a problem hiding this comment.
Can we use ll LTS?
Suggested change
| return heartbeat > 0 ? moment(heartbeat).format('YYYY/MM/DD HH:mm:ss') : 'NA'; | |
| return heartbeat > 0 ? moment(heartbeat).format('ll LTS') : 'NA'; |
| sorter: (a: IDatanode, b: IDatanode) => a.setupTime - b.setupTime, | ||
| render: (uptime: number) => { | ||
| return uptime > 0 ? moment(uptime).format('lll') : 'NA'; | ||
| return uptime > 0 ? moment(uptime).format('YYYY/MM/DD HH:mm:ss') : 'NA'; |
Contributor
There was a problem hiding this comment.
Suggested change
| return uptime > 0 ? moment(uptime).format('YYYY/MM/DD HH:mm:ss') : 'NA'; | |
| return uptime > 0 ? moment(uptime).format('ll LTS') : 'NA'; |
| key: 'lastLeaderElection', | ||
| render: (lastLeaderElection: number) => lastLeaderElection > 0 ? | ||
| moment(lastLeaderElection).format('lll') : 'NA', | ||
| moment(lastLeaderElection).format('YYYY/MM/DD HH:mm:ss') : 'NA', |
Contributor
There was a problem hiding this comment.
Suggested change
| moment(lastLeaderElection).format('YYYY/MM/DD HH:mm:ss') : 'NA', | |
| moment(lastLeaderElection).format('ll LTS') : 'NA', |
| const lastUpdatedText = lastUpdated === 0 ? 'NA' : | ||
| ( | ||
| <Tooltip | ||
| placement='bottom' title={moment(lastUpdated).format('lll')} |
Contributor
There was a problem hiding this comment.
Can we also update the tooltip to include seconds?
Suggested change
| placement='bottom' title={moment(lastUpdated).format('lll')} | |
| placement='bottom' title={moment(lastUpdated).format('ll LTS')} |
Contributor
Author
|
Thanks @vivekratnavel for review. I have changed the timestamp format.
|
Contributor
|
Thanks @runitao for the improvement and @vivekratnavel for the review. |
ChenSammi
pushed a commit
that referenced
this pull request
Jul 22, 2020
runitao
changed the title
timmylicheng
pushed a commit
that referenced
this pull request
Aug 6, 2020
avijayanhwx
pushed a commit
to avijayanhwx/hadoop-ozone
that referenced
this pull request
Aug 10, 2020
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Display more accurate timestamp in recon Web. Currently the web only show timestamp in minutes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3960
How was this patch tested?
Test with
pnpm run devHere is the result with this patch.
